Skip to content

Conversation

@pac48
Copy link
Contributor

@pac48 pac48 commented Aug 22, 2022

This PR provides an example for the admittance controller ros-controls/ros2_controllers#370. It contains the changes from #140 but with the needed changes for the new implementation.

Instructions for running the example are located here: using_admittance_controller.md.

```
1. Clone this moveit2 repository and import the `moveit2/moveit2.repos` file:
```
git clone https://github.com/pac48/moveit2.git -b pr-support-chained-controllers
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can get back on the main branch of MoveIt since that PR got merged 👍

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

cmake_minimum_required(VERSION 3.5)
project(rrbot_description)

find_package(ament_cmake REQUIRED)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess this demo doesn't belong in rrbot_description because it uses a UR robot. Prob should make a new package & directory for it.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@AndyZe AndyZe force-pushed the add-admittance-controller branch from 4528983 to bafe879 Compare September 23, 2022 15:22
@AndyZe AndyZe force-pushed the add-admittance-controller branch from bafe879 to 9700526 Compare September 23, 2022 15:41
AndyZe
AndyZe previously approved these changes Sep 23, 2022
Copy link
Contributor

@AndyZe AndyZe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I verified functionality 👍

sjahr
sjahr previously approved these changes Oct 7, 2022
Copy link

@sjahr sjahr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both demos worked well for me and I submitted a PR against the fork to update the dependencies, since they are slightly outdated by now.

@destogl destogl dismissed stale reviews from sjahr and AndyZe via 66c12e1 January 13, 2023 13:14
frame_id: wrist_3_link
additional_frames_to_publish: [base_link]

sensor_filter_chain:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How to define this using generate_parameters_library?

@christophfroehlich christophfroehlich added the New example This PR is proposing a new example. label Mar 17, 2023
@christophfroehlich christophfroehlich changed the title Add admittance controller demo [Example 15] Admittance controller demo Aug 5, 2023
@christophfroehlich christophfroehlich marked this pull request as draft September 6, 2023 08:37
@mergify
Copy link
Contributor

mergify bot commented Dec 18, 2023

This pull request is in conflict. Could you fix it @pac48?

@christophfroehlich christophfroehlich changed the title [Example 15] Admittance controller demo [Example XX] Admittance controller demo Dec 25, 2023
@pac48 pac48 closed this Apr 2, 2024
@christophfroehlich
Copy link
Contributor

@pac48 Does it make sense to update this to the current repo structure in your opinion?

@pac48
Copy link
Contributor Author

pac48 commented Apr 3, 2024

@christophfroehlich I think having an admittance control example could be useful, but it's probably easier to open a new PR at this point.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

New example This PR is proposing a new example.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants