Skip to content

Conversation

@tylerjw
Copy link
Contributor

@tylerjw tylerjw commented Jan 26, 2023

  • Fix overriding of install: hardware_interface
  • Fix overriding of install: controller_interface
  • Fix overriding of install: ros2_control_test_assets
  • Fix overriding of install: controller_manager
  • Fix overriding of install: controller_manager_msgs
  • Fix overriding of install: joint_limits
  • Fix overriding of install: transmission_interface
  • Upgrade CMake version

Description

This is related to:

Here are the colcon docs on overriding: https://colcon.readthedocs.io/en/released/user/overriding-packages.html#how-to-make-it-easier-for-your-users-to-override

Here is the ament_cmake user guide: https://docs.ros.org/en/rolling/How-To-Guides/Ament-CMake-Documentation.html

These changes have been tested locally and are in line with the changes we have been making to CMake for MoveIt. There are a few goals here:

  • Standardize the way we use CMake to be more declarative and modern
  • Correctly use the ament tooling so building a source copy of this repo on a machine with a binary install works (also called overriding)

One thing I did not do is turn on -Werror or increase the warning set when building this library. Given the time I'll follow up with PRs that fix the warnings and turn on -Werror.

Copy link
Member

@destogl destogl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree, just have two small comments that probably don't have to be discussed further.

@destogl destogl enabled auto-merge (squash) January 27, 2023 09:22
@destogl destogl merged commit 727297e into ros-controls:master Feb 10, 2023
mamueluth pushed a commit to b-robotized-forks/ros2_control that referenced this pull request Feb 16, 2023
pac48 pushed a commit to pac48/ros2_control that referenced this pull request Jan 26, 2024
@christophfroehlich christophfroehlich added the backport-humble Triggers PR backport to ROS 2 humble. label Aug 24, 2025
mergify bot pushed a commit that referenced this pull request Aug 24, 2025
Signed-off-by: Tyler Weaver <[email protected]>
(cherry picked from commit 727297e)

# Conflicts:
#	controller_interface/CMakeLists.txt
#	controller_interface/package.xml
#	controller_manager/CMakeLists.txt
#	controller_manager/package.xml
#	hardware_interface/CMakeLists.txt
#	joint_limits/CMakeLists.txt
#	ros2_control_test_assets/CMakeLists.txt
#	transmission_interface/CMakeLists.txt
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport-humble Triggers PR backport to ROS 2 humble.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants