-
Notifications
You must be signed in to change notification settings - Fork 372
Fix CMake install so overriding works #926
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tyler Weaver <[email protected]>
This was referenced Jan 26, 2023
destogl
approved these changes
Jan 27, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree, just have two small comments that probably don't have to be discussed further.
bmagyar
approved these changes
Feb 10, 2023
mamueluth
pushed a commit
to b-robotized-forks/ros2_control
that referenced
this pull request
Feb 16, 2023
Signed-off-by: Tyler Weaver <[email protected]>
pac48
pushed a commit
to pac48/ros2_control
that referenced
this pull request
Jan 26, 2024
mergify bot
pushed a commit
that referenced
this pull request
Aug 24, 2025
Signed-off-by: Tyler Weaver <[email protected]> (cherry picked from commit 727297e) # Conflicts: # controller_interface/CMakeLists.txt # controller_interface/package.xml # controller_manager/CMakeLists.txt # controller_manager/package.xml # hardware_interface/CMakeLists.txt # joint_limits/CMakeLists.txt # ros2_control_test_assets/CMakeLists.txt # transmission_interface/CMakeLists.txt
bmagyar
pushed a commit
that referenced
this pull request
Aug 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is related to:
Here are the colcon docs on overriding: https://colcon.readthedocs.io/en/released/user/overriding-packages.html#how-to-make-it-easier-for-your-users-to-override
Here is the ament_cmake user guide: https://docs.ros.org/en/rolling/How-To-Guides/Ament-CMake-Documentation.html
These changes have been tested locally and are in line with the changes we have been making to CMake for MoveIt. There are a few goals here:
One thing I did not do is turn on
-Werroror increase the warning set when building this library. Given the time I'll follow up with PRs that fix the warnings and turn on-Werror.