Resource Manager extension to support management of reference interfaces from chained controllers. #664
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
UsamaHamayun1,
aprotyas,
arne48,
bmagyar,
erickisos and
rosterloh
destogl
force-pushed
the
rm-extension-for-managing-reference-interfaces-pr
branch
from
d38a8ff to
7f00914
Compare
livanov93
approved these changes
Mar 31, 2022
destogl
force-pushed
the
rm-extension-for-managing-reference-interfaces-pr
branch
from
7f00914 to
9a58545
Compare
destogl
force-pushed
the
rm-extension-for-managing-reference-interfaces-pr
branch
from
9a58545 to
2dbd938
Compare
destogl
force-pushed
the
rm-extension-for-managing-reference-interfaces-pr
branch
from
2dbd938 to
767c247
Compare
bmagyar
reviewed
May 17, 2022
| resource_storage_->controllers_reference_interfaces_map_.at(controller_name); | ||
| resource_storage_->controllers_reference_interfaces_map_.erase(controller_name); | ||
|
|
||
| std::lock_guard<std::recursive_mutex> guard(resource_interfaces_lock_); |
There was a problem hiding this comment.
in other cases you put the guards into the function that is called. Is this different for any reason?
destogl
commented
May 18, 2022
destogl
commented
May 18, 2022
bmagyar
approved these changes
May 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces changes for Resource Manager regarding management of reference interfaces from chained controllers.
Resource Manager already has implemented management of Command (Read/Write) interfaces, therefore only methods for accessing reference interfaces specifically are created.
The main reason for putting the code here is to avoid code duplication in Controller Manager.
The PR doesn't depend on any PR specifically because the changes and functionality is limited to Resource Manager.