Fix ambiguous constructor overload (#499) (#500)

Author: mergify[bot]

control_toolbox/include/control_toolbox/pid_ros.hpp

@@ -77,14 +77,7 @@ class PidROS
       prefix_is_for_params)
   {
   }
-  template <class NodeT>
-  explicit PidROS(std::shared_ptr<NodeT> node_ptr, const std::string & param_prefix)
-  : PidROS(
-      node_ptr->get_node_base_interface(), node_ptr->get_node_logging_interface(),
-      node_ptr->get_node_parameters_interface(), node_ptr->get_node_topics_interface(),
-      param_prefix, "", false)
-  {
-  }
+
   /*!
    * \brief Constructor of PidROS class.
    *
@@ -93,7 +86,11 @@ class PidROS
    *
    * \param node Any ROS node
    * \param param_prefix prefix to add to the pid parameters.
-   * \param topic_prefix prefix to add to the state publisher. If it starts with `~/`, topic will be local under the namespace of the node. If it starts with `/` or an alphanumeric character, topic will be in global namespace.
+   * \param topic_prefix prefix to add to the state publisher.
+   *      If it starts with `~/`, topic will be local under the namespace of the node.
+   *      If it starts with `/` or an alphanumeric character, topic will be in global namespace.
+   *
+   * state publisher is not activated if topic_prefix is empty,
    *
    */
   template <class NodeT>
@@ -103,7 +100,7 @@ class PidROS
   : PidROS(
       node_ptr->get_node_base_interface(), node_ptr->get_node_logging_interface(),
       node_ptr->get_node_parameters_interface(), node_ptr->get_node_topics_interface(),
-      param_prefix, topic_prefix, true)
+      param_prefix, topic_prefix, !topic_prefix.empty())
   {
   }
   /*!
@@ -114,7 +111,9 @@ class PidROS
    *
    * \param node Any ROS node
    * \param param_prefix prefix to add to the pid parameters.
-   * \param topic_prefix prefix to add to the state publisher. If it starts with `~/`, topic will be local under the namespace of the node. If it starts with `/` or an alphanumeric character, topic will be in global namespace.
+   * \param topic_prefix prefix to add to the state publisher.
+   *      If it starts with `~/`, topic will be local under the namespace of the node.
+   *      If it starts with `/` or an alphanumeric character, topic will be in global namespace.
    * \param activate_state_publisher If true, the publisher will be enabled after initialization.
    *
    */