Create a healthy culture #84
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adlamas
commented
Sep 25, 2023
|
|
||
| class PeopleService | ||
| def getPeople | ||
| people = Person.all |
There was a problem hiding this comment.
Agressive comment
Have you read Ruby's guides for methods namings? Obviously, this is not the way. Also, didn't you see this is not correctly indented? You can't make these errors.
|
|
||
| return people | ||
| end | ||
| end |
There was a problem hiding this comment.
Correct comment
Usually, we use snake case for method naming, so maybe we can adapt it. Also, there was a problem with indentation, perhaps, can we reduce it in one space? What do you think? 🤔
Thanks 😄
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discussion Link
Description: