-
Notifications
You must be signed in to change notification settings - Fork 1.4k
[tutorials] Return void instead of TCanvas* in histogram tutorials #20285
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
hahnjo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tutorials are run as part of the CI, so I would argue the PR should not be marked [skip-ci] and only discover problems after the merge (it happened in the past)
linev
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also please start CI - some tutorials used for testing, which rely on the fact that non-zero value returned by such tutorial.
81233b5 to
7f1977d
Compare
|
Now looks better - but let see CI first |
Test Results 21 files 21 suites 3d 16h 33m 17s ⏱️ Results for commit c627f1e. ♻️ This comment has been updated with latest results. |
linev
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now looks ok. Please wait for CI
This Pull request:
Update the histogram tutorials to return
voidinstead of aTCanvas*, which is also the convention used in other ROOT tutorials.This is required for testing in the Python wheels workflow #19600 since running
root tutorial.Cin this context returns code255, causingpytestto flag the test as failed.See failure message:
Checklist: