[core] Add TColorNumber constructor from a C-style string #20271
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We also require an overload for C-style strings. That's because the TColorNumber is designed to be constructed implicitly, and C++ won't do two user-defined conversions in a single implicit conversion chain.
Test Results 22 files 22 suites 3d 16h 21m 52s ⏱️ Results for commit 538ebdb. ♻️ This comment has been updated with latest results. |
vepadulano
approved these changes
Nov 3, 2025
Member
vepadulano
left a comment
vepadulano
left a comment
There was a problem hiding this comment.
LGTM thanks, could you point this to the other PR so that we understand the use case?
Contributor
|
Thanks! I adapted #20258 accordingly |
siliataider
approved these changes
Nov 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We also require an overload for C-style strings. That's because the TColorNumber is designed to be constructed implicitly, and C++ won't do two user-defined conversions in a single implicit conversion chain.