[DO NOT MERGE] Show test failures for #20222 #20263
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The general idea for this test suite is to have one single source of data, a TChain, that is befriended by a long enough friendship hierarchy, namely four consecutive layers of friends. The outermost dataset is the one that drives the event loop, either via SetBranchAddress + raw loop or via TTree::Scan. The data comes from the innermost TChain. All the combinations of TTree/TChain at the various steps of the hierarchy are tried. Furthermore, TTree::Scan is called with an increasingly larger starting entry to ensure that even when starting e.g. from an entry of the second tree of the innermost chain the Scan works well.
Add a test suite for the scenario of multiple levels of friendship hierarchy where all TTree/TChain datasets in the hierarchy have a branch with exactly the same name. Call TTree::Scan and make sure that the correct branch from the correct TTree is accessed with every possible combination of using TTree/TChain to steer the execution or only one or more of the branches of the hierarchy. This scenario represents the use case of comparing the same quantity which can pass through various derivation steps and each step must be compared with the other ones.
Introduce a test with a long friendship hierarchy where data is accessed via TTree::Scan. Every dataset in the hierarchy has the same branch name. The Scan expression uses different branch names from every dataset in the same component of the expression. This checks that the branch addresses are properly set and they don't get mixed up.
Tests that a TChain with a name different than its inner TTree can find a branch of the TTree when the user passes a branch lookup string of the form "chainName.branchName".
Tests that a TTree that has a TChain friend can retrieve a branch from the inner TTree of the friend TChain by prefixing the branch name with the chain name, even if the inner TTree of the friend TChain might have a different name than the chain name.
Test Results 21 files 21 suites 3d 19h 21m 48s ⏱️ For more details on these failures, see this check. Results for commit 64bf82a. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discussed privately with @pcanal, this PR shows the test failures occurring without the fixes proposed by #20222