Fix many problems in TGraphPainter::PaintGraphReverse
#20236
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If both options are specified, X painting can be corrupted. While gPad->Update called after reverse X axis was painted - removing everything again. Now call gPad->Update() inside PaintGraphReverse before actual reverse axes are painted.
Delete temporary TGraph and TGaxis objects used only for painting. These objects do not appears in canvas list of primitives, therfore cannot be cleaned up
Visisble Y range configured in the fMinimum/fMaximum values of histogram and not in the axis properties. Extra handling unzoom action when fMinimum == fMaximum == 0. More important - remove unnecessary gPad->Update() to prevent unpredictable results during painting. Resolves error with new stressGraphics tests
couet
approved these changes
Oct 30, 2025
Test Results 22 files 22 suites 3d 22h 37m 40s ⏱️ Results for commit de83449. |
Member
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This method used when graph drawn with "rx" or "ry" draw option.
Example is: https://github.com/root-project/root/blob/master/roottest/graphics/macros/graphs/graphreverse.C
Following problems are resolved:
fMininum/fMaximummembers of histogram. So one have to use these values for painting of Y axis.Unzoomof Y axis - fMinimum/fMaximum of histogram set to 0 and need to be properly configured again.gPad->Update()inside painter which completely screw-up painting of TCanvas making wired PS/SVG output. Found with new stressGraphics tests in Increase number of tests in stressGraphics #20216