-
Notifications
You must be signed in to change notification settings - Fork 1.4k
[hist] Implement initial RHistEngine
#19732
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Test Results 20 files 20 suites 3d 18h 20m 11s ⏱️ For more details on these failures, see this check. Results for commit 564533a. ♻️ This comment has been updated with latest results. |
Needed in the public interface of the histogram classes, so it should not be in the Internal namespace.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! The below comments are mostly for the documentation or usability.
dba1106
to
8928a0d
Compare
It combines an RAxes object and storage of bin contents.
This results in proper error messages when trying to stream. Other instantiations will be caught by the RAxes member.
It combines an
RAxes
object and storage of bin contents.