Skip to content

Conversation

hahnjo
Copy link
Member

@hahnjo hahnjo commented Aug 23, 2025

It combines an RAxes object and storage of bin contents.

@hahnjo hahnjo self-assigned this Aug 23, 2025
@hahnjo hahnjo added the in:Hist label Aug 23, 2025
@hahnjo hahnjo requested a review from bellenot as a code owner August 23, 2025 13:55
Copy link

github-actions bot commented Aug 23, 2025

Test Results

    20 files      20 suites   3d 18h 20m 11s ⏱️
 3 657 tests  3 656 ✅ 0 💤 1 ❌
71 458 runs  71 452 ✅ 5 💤 1 ❌

For more details on these failures, see this check.

Results for commit 564533a.

♻️ This comment has been updated with latest results.

Needed in the public interface of the histogram classes, so it should
not be in the Internal namespace.
Copy link
Member

@hageboeck hageboeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! The below comments are mostly for the documentation or usability.

@hahnjo hahnjo force-pushed the hist-engine branch 2 times, most recently from dba1106 to 8928a0d Compare September 2, 2025 14:36
It combines an RAxes object and storage of bin contents.
This results in proper error messages when trying to stream. Other
instantiations will be caught by the RAxes member.
@hahnjo hahnjo merged commit f605857 into root-project:master Sep 4, 2025
43 of 47 checks passed
@hahnjo hahnjo deleted the hist-engine branch September 4, 2025 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants