Skip to content

[cmake] allow disabling Gui #19381

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

silverweed
Copy link
Contributor

This Pull request:

Adds a gui build option that allows disabling the Gui library. It is meant to be used in conjunction with minimal=on as no effort is made to make sure that the option is coherent with the set of other options, meaning turning the gui off by itself won't automatically disable all its dependent modules. However, when minimal is on, everything works fine.

Rationale

When someone builds with minimal=on they don't care about graphics (otherwise they'd use gminimal) and building the graphics libraries is a waste of time. AFAIK, the gui already doesn't work when building with minimal=on, so we can spare time by not building it.

Ideally we should be able to also disable graf2d and graf3d, however too many core packages depend on them to be as easily doable (we'd have to disable half of the math/tree/hist modules and rethink modules.idx and hsimple.root), so that'll remain a wish for the future.

Checklist:

  • tested changes locally
  • updated the docs (if necessary)

@silverweed silverweed self-assigned this Jul 15, 2025
@silverweed silverweed requested a review from bellenot as a code owner July 15, 2025 14:52
@silverweed silverweed changed the title [cmake] allow disabling gui [cmake] allow disabling Gui Jul 15, 2025
@vepadulano
Copy link
Member

Just a fly-by comment

the gui already doesn't work when building with minimal=on

I can confirm this

Copy link

Test Results

    21 files      21 suites   3d 16h 47m 31s ⏱️
 3 211 tests  3 209 ✅ 0 💤 2 ❌
65 699 runs  65 695 ✅ 2 💤 2 ❌

For more details on these failures, see this check.

Results for commit c61b5c9.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants