Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pull request:
Adds a
gui
build option that allows disabling the Gui library. It is meant to be used in conjunction withminimal=on
as no effort is made to make sure that the option is coherent with the set of other options, meaning turning the gui off by itself won't automatically disable all its dependent modules. However, when minimal is on, everything works fine.Rationale
When someone builds with
minimal=on
they don't care about graphics (otherwise they'd usegminimal
) and building the graphics libraries is a waste of time. AFAIK, the gui already doesn't work when building withminimal=on
, so we can spare time by not building it.Ideally we should be able to also disable graf2d and graf3d, however too many core packages depend on them to be as easily doable (we'd have to disable half of the math/tree/hist modules and rethink
modules.idx
andhsimple.root
), so that'll remain a wish for the future.Checklist: