[rdf] Fix dataframe_snapshot tests on Windows #19379
Merged
+39
−38
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`dataframe_snapshot.cxx`: Fix the following compilation error: ``` dataframe_snapshot.cxx(1000,34): error C2326: 'RDFSnapshotMore_CompositeTypeWithNameClash_Test::TestBody::FileGuard::~FileGuard(void)': function cannot access 'fName' ``` and the following run-time error: ``` 467: [ RUN ] RDFSnapshotMore.Lazy 467: C:\root-dev\git\master\tree\dataframe\test\dataframe_snapshot.cxx(860): error: Value of: gSystem->AccessPathName(fname1) 467: Actual: false 467: Expected: true ``` `dataframe_snapshot_ntuple.cxx`: Fix the following error: ``` 469: [ RUN ] RDFSnapshotRNTupleTest.InnerFields 469: ROOT::TestSupport::ForbidDiagnostics::handler(): Diagnostic in 'Snapshot': 469: Column electron.pt will be saved as electron_pt 469: ROOT::TestSupport::ForbidDiagnostics::handler(): Diagnostic in 'Snapshot': 469: Column jets.electrons will be saved as jets_electrons 469: C:\root-dev\git\master\core\testsupport\src\TestSupport.cxx(81): error: Failed 469: Received unexpected diagnostic of severity 5000 at 'TFile::TFile' reading 'could not delete C:\root-dev\build\x64\relwithdebinfo\tree\dataframe\test\RDFSnapshotRNTuple_inner_fields.root (errno: 13) Permission denied'. 469: Suppress those using ROOT/TestSupport.hxx 469: unknown file: error: C++ exception with description "Snapshot: could not create output file RDFSnapshotRNTuple_inner_fields.root" thrown in the test body. 469: [ FAILED ] RDFSnapshotRNTupleTest.InnerFields (110 ms) ```
Test Results 21 files 21 suites 3d 12h 19m 38s ⏱️ Results for commit ea8f06c. ♻️ This comment has been updated with latest results. |
vepadulano
approved these changes
Jul 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dataframe_snapshot.cxx: Fix the following compilation error:and the following run-time error:
dataframe_snapshot_ntuple.cxx: Fix the following error: