[cling] Use clang-repl-style code completion #19375
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch tries to mirror the approach taken by clang-repl for autocomplete, will enable auto-complete without the overhead of a full nested interpreter
This patch eliminates the need to create a nested interpreter for code completion. In LLVM 19, some Sema internals became private: See llvm/llvm-project@874f511 Without this, we would require an additional patch on top of Clang to access `Sema::CodeCompleter` after upgrading to LLVM 20.
Test Results 20 files 20 suites 3d 7h 27m 23s ⏱️ For more details on these failures, see this check. Results for commit 5cb49d0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pull request:
This patch eliminates the need to create a nested interpreter for code
completion.
In LLVM 19, some Sema internals became private:
See llvm/llvm-project@874f511
Without this, we would require an additional patch on top of Clang to
access
Sema::CodeCompleterafter upgrading to LLVM 20.This will fix one of the failing test during upgrade in CppInterOp (autocomplete)
Changes or fixes:
Checklist:
This PR fixes #