Skip to content

[hist] Skip empty bins when add/filling sparse hist #19367

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

[hist] Skip empty bins when add/filling sparse hist #19367

wants to merge 3 commits into from
+19 −2

Conversation

ferdymercury
Copy link
Collaborator

@ferdymercury ferdymercury commented Jul 14, 2025 •
edited
Loading

This Pull request:

Changes or fixes:

Fixes #19366

fyi @Zehvogel

Checklist:

  • tested changes locally
  • updated the docs (if necessary)

@ferdymercury ferdymercury marked this pull request as ready for review July 14, 2025 17:21
@ferdymercury ferdymercury requested a review from lmoneta as a code owner July 14, 2025 17:21
@github-actions GitHub Actions
Copy link

Test Results

    21 files      21 suites   3d 9h 18m 35s ⏱️
 3 203 tests  3 194 ✅ 0 💤 9 ❌
65 570 runs  65 561 ✅ 0 💤 9 ❌

For more details on these failures, see this check.

Results for commit 761cc35.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lmoneta lmoneta Awaiting requested review from lmoneta lmoneta is a code owner

@guitargeek guitargeek Awaiting requested review from guitargeek

@hageboeck hageboeck Awaiting requested review from hageboeck

At least 1 approving review is required to merge this pull request.

Assignees

@hageboeck hageboeck

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

THnSparse::CreateSparse creates histograms that are not sparse
2 participants
@ferdymercury @hageboeck