-
Notifications
You must be signed in to change notification settings - Fork 1.4k
[df] Introduce RDatasetSpec for RNTuple #19341
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[df] Introduce RDatasetSpec for RNTuple #19341
Conversation
3645459
to
48101c1
Compare
Test Results 21 files 21 suites 3d 7h 39m 15s ⏱️ Results for commit 6ed4a6a. ♻️ This comment has been updated with latest results. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello, thanks for the development!
I left already a few comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see a few shadow warnings in the CI, but you probably saw them, too.
48101c1
to
e23f84e
Compare
2f19a35
to
59f61b2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for this work! Some minor suggestions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice thank you!! 🚀
Before merging please squash the commits 👍 |
dfc093f
to
6ed4a6a
Compare
This PR introduces functionality of RDatasetSpec for RNTuple. Main changes are inside RLoopManager and RNTupleDS - mainly the introduction of WithGlobalRanges.
Marked as WIP to make sure all tests pass but the main development should be ready for the review.