Skip to content

[df] Introduce RDatasetSpec for RNTuple #19341

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 29, 2025

Conversation

martamaja10
Copy link
Contributor

This PR introduces functionality of RDatasetSpec for RNTuple. Main changes are inside RLoopManager and RNTupleDS - mainly the introduction of WithGlobalRanges.

Marked as WIP to make sure all tests pass but the main development should be ready for the review.

@martamaja10 martamaja10 self-assigned this Jul 11, 2025
@martamaja10 martamaja10 force-pushed the datasetspec-rntuple branch from 3645459 to 48101c1 Compare July 11, 2025 09:51
Copy link

github-actions bot commented Jul 11, 2025

Test Results

    21 files      21 suites   3d 7h 39m 15s ⏱️
 3 218 tests  3 218 ✅ 0 💤 0 ❌
65 855 runs  65 855 ✅ 0 💤 0 ❌

Results for commit 6ed4a6a.

♻️ This comment has been updated with latest results.

Copy link
Member

@hageboeck hageboeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello, thanks for the development!

I left already a few comments.

Copy link
Member

@hageboeck hageboeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see a few shadow warnings in the CI, but you probably saw them, too.

@martamaja10 martamaja10 force-pushed the datasetspec-rntuple branch from 48101c1 to e23f84e Compare July 21, 2025 12:42
@martamaja10 martamaja10 marked this pull request as ready for review July 21, 2025 13:46
@martamaja10 martamaja10 changed the title [WIP][df] Introduce RDatasetSpec for RNTuple [df] Introduce RDatasetSpec for RNTuple Jul 21, 2025
@martamaja10 martamaja10 reopened this Jul 24, 2025
@martamaja10 martamaja10 force-pushed the datasetspec-rntuple branch 2 times, most recently from 2f19a35 to 59f61b2 Compare July 26, 2025 16:27
Copy link
Member

@vepadulano vepadulano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this work! Some minor suggestions

Copy link
Member

@vepadulano vepadulano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice thank you!! 🚀

@vepadulano
Copy link
Member

Before merging please squash the commits 👍

@martamaja10 martamaja10 force-pushed the datasetspec-rntuple branch from dfc093f to 6ed4a6a Compare July 29, 2025 13:03
@martamaja10 martamaja10 merged commit ba880fe into root-project:master Jul 29, 2025
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants