Skip to content

[hist] Implement initial RRegularAxis and RVariableBinAxis #19334

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 21, 2025

Conversation

hahnjo
Copy link
Member

@hahnjo hahnjo commented Jul 10, 2025

The first versions of these classes expose only ComputeLinearizedIndex with simple implementations. Further improvements and optimizations are possible in the future.

This PR also includes basic build system additions and setup for unit testing.

@hahnjo hahnjo self-assigned this Jul 10, 2025
@hahnjo hahnjo requested a review from bellenot as a code owner July 10, 2025 15:45
@hahnjo hahnjo added the in:Hist label Jul 10, 2025
Copy link

github-actions bot commented Jul 10, 2025

Test Results

    21 files      21 suites   3d 8h 4m 15s ⏱️
 3 213 tests  3 213 ✅ 0 💤 0 ❌
65 744 runs  65 744 ✅ 0 💤 0 ❌

Results for commit da1c254.

♻️ This comment has been updated with latest results.

Copy link
Member

@dpiparo dpiparo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this new development, proposed after a long campaign of design, discussions and thinking. Looking forward to see the rest of the "new histogram classes federation"!

Copy link
Contributor

@jblomer jblomer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello, histv7!

@hahnjo hahnjo force-pushed the hist-axis branch 2 times, most recently from 37f25cf to da1c254 Compare July 16, 2025 08:46
Copy link
Member

@hageboeck hageboeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only one small comment

Copy link
Contributor

@siliataider siliataider left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's go histv7 🚀

hahnjo added 2 commits July 21, 2025 17:09
The first version of this class exposes only ComputeLinearizedIndex
with a simple index computation formula. It does not (yet) implement
the recent changes to improve its precision available in TAxis.

This commit also includes basic build system additions and setup for
unit testing.
As for the initial version of RRegularAxis, this first commit only
exposes ComputeLinearizedIndex with a simple linear search.
@hahnjo hahnjo merged commit b07b6ed into root-project:master Jul 21, 2025
43 of 45 checks passed
@hahnjo hahnjo deleted the hist-axis branch July 21, 2025 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants