-
Notifications
You must be signed in to change notification settings - Fork 1.4k
[hist] Implement initial RRegularAxis
and RVariableBinAxis
#19334
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Test Results 21 files 21 suites 3d 8h 4m 15s ⏱️ Results for commit da1c254. ♻️ This comment has been updated with latest results. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this new development, proposed after a long campaign of design, discussions and thinking. Looking forward to see the rest of the "new histogram classes federation"!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello, histv7!
37f25cf
to
da1c254
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only one small comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's go histv7 🚀
The first version of this class exposes only ComputeLinearizedIndex with a simple index computation formula. It does not (yet) implement the recent changes to improve its precision available in TAxis. This commit also includes basic build system additions and setup for unit testing.
As for the initial version of RRegularAxis, this first commit only exposes ComputeLinearizedIndex with a simple linear search.
The first versions of these classes expose only
ComputeLinearizedIndex
with simple implementations. Further improvements and optimizations are possible in the future.This PR also includes basic build system additions and setup for unit testing.