Remove empty directories from TFileMerger's output #19331
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Doxygen was squashing this block into a paragraph, so it needed to be split off and indented.
1 task
Test Results 20 files 20 suites 3d 6h 14m 18s ⏱️ Results for commit 5f1efc2. ♻️ This comment has been updated with latest results. |
silverweed
requested changes
Jul 11, 2025
Partial merging creates a full directory hierarchy in an output file, even if the user didn't ask for the directories to be merged. Fix root-project#19330.
silverweed
approved these changes
Jul 11, 2025
The current state is draft, is it ready for review? |
pcanal
reviewed
Jul 15, 2025
|
|
||
| { | ||
| TFileMerger fileMerger(false); | ||
| fileMerger.AddFile(input); |
There was a problem hiding this comment.
For completeness sake, consider using 2 files, selecting 3 histos in the subdirectory(ies) with one of the histos in both file, one of the histo in only the first file, one of the histo only in the second file (in addition to all the histo that are not selected and can be in both files).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
even if the user didn't ask for the directories to be merged.
PartialMergeUpdate:
#19330