[WIP][Python] Unify maps used for numpy to cpp conversion #19321
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results 20 files 20 suites 3d 10h 35m 19s ⏱️ For more details on these failures, see this check. Results for commit b016053. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pull request:
Warning
This PR is still under development. I am opening it as a draft to see if this small refactoring breaks a lot of tests, before moving forward with broader changes.
Currently, multiple dictionaries for mapping numpy dtypes to C++ types exist, such as:
_array_interface_dtype_map.cpptypes.array_conversions,array_interfaceandrtensordefine their own conversion helpersThe goal is to address some of the inconsistencies by refactoring the existing maps into one clear set of types allowed for conversion between NumPy and c++.
This PR fixes #18390