Skip to content

[cling] Deduplicate cling::utils::TypeName::GetFullyQualifiedName #19293

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

devajithvs
Copy link
Contributor

@devajithvs devajithvs commented Jul 5, 2025

This Pull request:

Work in Progress: Uses upstream GetFullyQualifiedName but has diverged quite a bit and there are failing tests locally

Changes or fixes:

Checklist:

  • tested changes locally
  • updated the docs (if necessary)

This PR fixes #18622

@guitargeek
Copy link
Contributor

guitargeek commented Jul 5, 2025

Ha, that's funny! I was just touching the same code because there was an easy Jira issue to fix:

Maybe you can take the unit test from that PR and put it here too? The reproducer should also be fixed by what you're doing here. Or we merge my PR before? As you prefer.

@devajithvs
Copy link
Contributor Author

Ha, that's funny! I was just touching the same code because there was an easy Jira issue to fix:

Maybe you can take the unit test from that PR and put it here too? The reproducer should also be fixed by what you're doing here. Or we merge my PR before? As you prefer.

Yes, I saw your PR. I think it’s better that your PR is merged first. I need to look a bit more into the failing cases.

Copy link

github-actions bot commented Jul 5, 2025

Test Results

    20 files      20 suites   3d 5h 37m 3s ⏱️
 3 192 tests  3 141 ✅ 0 💤  51 ❌
62 241 runs  62 099 ✅ 0 💤 142 ❌

For more details on these failures, see this check.

Results for commit 99b850c.

@guitargeek
Copy link
Contributor

Well, my PR has the same problems.

Could it be a clang upstream problem? I noticed that even with LLVM 20, printing out the qual type of the std::vector<T>::at method is missing the template arguments of the function argument types:

std::vector<int>::reference (std::vector<int>::*)(std::vector::size_type)

I used the following policy when printing:

PrintingPolicy Policy(Context->getPrintingPolicy());

Policy.FullyQualifiedName = true;
Policy.SuppressElaboration = true;

Maybe this should be fixed upstream?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[cling] Deduplicate cling::utils::TypeName::GetFullyQualifiedName
2 participants