Add bool to allowed conversion between numpy arrays and RVec

[Aditya-138-12]

This Pull request:

Add support for NumPy boolean type 'b1' in RVec conversion

Changes or fixes:

Modify _get_cpp_type_from_numpy_type function in _rvec.py to map NumPy's 'b1', thereby adding this in the dict cppytypes "b1":"bool"

Checklist:

• tested changes locally
• updated the docs (if necessary)

This PR fixes #18085

[Aditya-138-12]

Hi @vepadulano @dpiparo
Can we also add other types like 8 bit usigned integer i1 ?... so that possibly this kind of bug may not arise in future?

[github-actions]

Test Results

    18 files      18 suites   4d 10h 56m 31s ⏱️
 2 721 tests  2 721 ✅ 0 💤 0 ❌
47 506 runs  47 506 ✅ 0 💤 0 ❌

Results for commit 1170796.

♻️ This comment has been updated with latest results.

[Aditya-138-12]

Hi @vepadulano , I have added 4 more types.

Please tell us why you approve this request.

[vepadulano]

Thanks for addressing the issue! I left a minor comment inline, then I believe we need more tests in test/rvec_asrvec.py. The list of dtypes in the AsRVec test case class should be extended to include all the dtypes represented in the map after the changes.

[vepadulano]

Thank you for reverting back to the original change to fix the related issue @Aditya-138-12! I believe the extension of the type map was a good idea, but the issues that arose from it are unrelated to fixing the original problem and will need more careful attention, to be left for a follow-up PR 👍

[lwpiotr]

Shouldn't short and unsigned short also be added here?

[vepadulano]

Thank you @Aditya-138-12 , LGTM!

[vepadulano]

Shouldn't short and unsigned short also be added here?

Hi @lwpiotr ! Thanks for showing interest in this PR! As you can see from the previous comments, this was already attempted by the author, but different issues arose which are unrelated to the request from the user at the linked issue. In general, I agree this type conversion map could be further extended, but it is beyond the scope of this PR 👍 Feel free to propose a new PR to address the changes!

[Aditya-138-12]

Thank you @Aditya-138-12 , LGTM!

@vepadulano Thank you for your time and guidance!!