Skip to content
This repository was archived by the owner on Aug 4, 2021. It is now read-only.
This repository was archived by the owner on Aug 4, 2021. It is now read-only.

Browser option error #128

@Antonio-Laguna

Description

@Antonio-Laguna

Hey here,

It seems 3.0.1 introduces a regression on this plugin regarding the browser option. One of the checks is like this:

else if (options.browser && pkg[ 'browser' ][ pkg[ 'main' ] ]) {

Which looks rather unsafe to me. If for some reason pkg['browser'] is not there, this just blows as it can read property of undefined. Was this intentional? Am I doing something wrong? Or is this a legit bug?

Kind to submit a PR to make that if a tad safer.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions