Remove the schema prefix when we do joins #10
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
I also tried the tests without the fix and I would get error like : |
Summary On the columns that are part of the clause for a join, remove the schema prefix by creating an alias based on the table and setting the `table` attribute of the columns in the join clause to be alias and not the table. The name of the alias is picked to be the name of the table as well as it works in plain SQL. We only do that if: 1. there is a schema prefix on the table (ie. `commons` or `production`) 2. the "table" is not actually already an alias 3. the "table" is not actually a subquery Testing I created unit tests for the visit_join function they are all passing. I also created a wheel package and uploaded it in `superset`, I used to have issues with queries when superset wanted to do a self join to limit the number of series returned in a query. It was complaining: ``` Relation name `commons` not found. If you are trying to access a nested field within an object ``` With the fix the query is working fine.
haneeshr
approved these changes
Mar 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
On the columns that are part of the clause for a join, remove the schema
prefix by creating an alias based on the table and setting the
tableattribute of the columns in the join clause to be alias and not the
table.
The name of the alias is picked to be the name of the table as well as
it works in plain SQL.
We only do that if:
commonsorproduction)Testing
I created unit tests for the visit_join function they are all passing.
I also created a wheel package and uploaded it in
superset, I used tohave issues with queries when superset wanted to do a self join to limit
the number of series returned in a query.
It was complaining:
With the fix the query is working fine.