tests: avoid ephemeral test suite failure on slow CI #2368
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In debian's build daemon architecture, some machines are heavily congested (especially for more obscure ports with lower-resourced machines)), and a build can be delayed at any point. If a build happens to be paused for more than a minute at the wrong time, this test can fail, as it did here, on the sparc64 architecture: https://buildd.debian.org/status/fetch.php?pkg=rnp&arch=sparc64&ver=0.18.0-4&stamp=1760765792&raw=0 The failure was that the certificate showed as "EXPIRED" instead of "EXPIRES". This fix isn't a complete fix -- test_set_expires will still fail on some extremely slow machines, for example if the build is delayed by 10 hours at the wrong moment, the subsequent test will fail. But this should significantly reduce the frequency of build failures.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## release/0.x #2368 +/- ##
============================================
Coverage 85.46% 85.46%
============================================
Files 126 126
Lines 22710 22710
============================================
Hits 19408 19408
Misses 3302 3302 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull Request Overview
This PR addresses intermittent test failures on slow or congested CI systems by making the test assertion more flexible regarding certificate expiration status messages.
- Modifies the regex pattern in
test_set_expireto accept both "EXPIRES" and "EXPIRED" status messages
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In debian's build daemon architecture, some machines are heavily congested (especially for more obscure ports with lower-resourced machines)), and a build can be delayed at any point.
If a build happens to be paused for more than a minute at the wrong time, this test can fail, as it did here, on the sparc64 architecture:
https://buildd.debian.org/status/fetch.php?pkg=rnp&arch=sparc64&ver=0.18.0-4&stamp=1760765792&raw=0
The failure was that the certificate showed as "EXPIRED" instead of "EXPIRES".
This fix isn't a complete fix -- test_set_expires will still fail on some extremely slow machines, for example if the build is delayed by 10 hours at the wrong moment, the subsequent test will fail.
But this should significantly reduce the frequency of build failures.