Fix 32 bit assertion #2363
Fix 32 bit assertion #2363
Conversation
|
this doesn't seem to be sufficient for 32-bit platforms. i'm still looking for other issues. |
|
@dkg I hope to get back to this and other CI issues during the weekend. |
Many systems with 32-bit memory space (e.g. debian's armhf platform) in fact have a 32-bit time_t. Recent versions of python (3.12 and higher) have a much better test for sizeof(time_t). If that's available, RNP should use that instead of the clumsier sys.maxsize.
|
I've just pushed another fix for 32-bit platforms to this branch. these two fixes together combine to let the test suite succeed on debian's |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## release/0.x #2363 +/- ##
============================================
Coverage 85.46% 85.46%
============================================
Files 126 126
Lines 22710 22710
============================================
Hits 19408 19408
Misses 3302 3302 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
just a gentle nudge on this. is this patch unacceptable for some reason? |
2 participants
No description provided.