Skip to content

Conversation

@ni4
Copy link
Contributor

@ni4 ni4 commented Oct 7, 2024

As title says.

@ni4 ni4 force-pushed the ni4-fix-windows-ci-failure branch from 9b5cfc9 to da09da2 Compare October 7, 2024 09:09
@ni4 ni4 mentioned this pull request Oct 7, 2024
@codecov
Copy link

codecov bot commented Oct 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.27%. Comparing base (9329129) to head (da09da2).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2282   +/-   ##
=======================================
  Coverage   84.27%   84.27%           
=======================================
  Files         114      114           
  Lines       23324    23324           
=======================================
  Hits        19656    19656           
  Misses       3668     3668           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@maxirmx maxirmx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ni4
Copy link
Contributor Author

ni4 commented Oct 7, 2024

Thanks, @maxirmx ! Merging with single approval as CI-only and blocking other PRs.

@ni4 ni4 merged commit 0015432 into main Oct 7, 2024
124 checks passed
@ni4 ni4 deleted the ni4-fix-windows-ci-failure branch October 7, 2024 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants