feat(Directive) update to new spec for Directive locations #121
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rmosolgo
force-pushed
the
update-directive-introspection
branch
2 times, most recently
from
68d70a7 to
bede327
Compare
rmosolgo
force-pushed
the
update-directive-introspection
branch
from
bede327 to
edb0a91
Compare
| @@ -4,7 +4,5 @@ | |||
| field :name, !types.String, "The name of this directive" | |||
| field :description, types.String, "The description for this type" | |||
| field :args, field: GraphQL::Introspection::ArgumentsField | |||
| field :onOperation, !types.Boolean, "Does this directive apply to operations?", property: :on_operation? | |||
There was a problem hiding this comment.
Why did you remove this and not deprecate it like GraphQL JS? This breaks ecosystem tools like GraphiQL that have not yet updated.
There was a problem hiding this comment.
Oops, error on my part! They can be re-implemented & marked as deprecated, sorry!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A little bit ago, the Directive spec changed: graphql/graphql-spec#152
So, update!