Supports ever changing lang folder #170
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rmariuzzo
approved these changes
Aug 26, 2022
|
Guys please... Not the Fix Friday again! @wilpat @rmariuzzo
My advice is to enable at least double review, if anyone (e.g. our projects) has the dependency set to Please flag the version as non-working as soon as possible. |
|
@Chomiciak I apologize for this, that's on me. I removed the broken version from Packagist, I think that should alleviate that issue. Please, let me know if not. |
|
Also, I appreciate your advice, I will make a call for more maintainers to make double review as you suggested. |
rmariuzzo
added a commit
that referenced
this pull request
Aug 26, 2022
This reverts commit 9e570ee.
bcalik
reviewed
Sep 17, 2022
| $langs = $app['path.base'].'/app/lang'; | ||
| } elseif ($laravelMajorVersion >= 5) { | ||
| $languagePath = 'resources/lang'; | ||
| } |
There was a problem hiding this comment.
Its better to use app()->langPath() instead of all this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From laravel 4 to 8.x we've seen changes to where the
langfolder lives and this breaks the functionality of this package.This PR makes this path customisable, so the package does not need to be updated every time laravel makes an update to the location of this folder.