Feature tool call for swe agent #289
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…_calling outside SWEAgent
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AgentExecutionEngine.get_model_response()should returnModelOutputinstead of response text.Response text was already converted to
ModelOutputin rollout_engines, so no need to getModelOutput.textand re-parse it inagent.update_from_modelAdded tool definitions after sys prompt in
agent.reset()like ToolAgent did.Also, I noticed that
kwargs["tools"]was never passed to rollout_engine -> parser, so I added a entry pointagent.get_tools_for_rollout_engine(). Developers can choose to implget_tools_for_rollout_engine, then parser will add tool definitions after sys prompt.