Feat: resolve / reject dialogs #14
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I suggest an API change to be able to reject the underlying promise of a dialog, by calling either
resolveDialog()
orrejectDialog()
instead ofcloseDialog()
.When
rejectDialog()
is invoked (when clicking on a cancel button, for instance), it rejects the underlying promise with aDismissedDialog
error.Useful when chaining dialogs, this allows turning this:
into this:
I kept
closeDialog()
for BC - when you pass anError
intocloseDialog()
, it will internally callrejectDialog()
.