Skip to content

Feat: fallback to undefined #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Feat: fallback to undefined #13

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions lib/ts/lib.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,9 +15,9 @@ export const dialogRef = shallowRef<DialogInstance>();
* Closes the currently opened dialog, resolving the promise with the return value of the dialog, or with the given
* data if any.
*/
export function closeDialog(data?: any) {
export function closeDialog(data?: any): void {
if (data === undefined) {
data = dialogRef.value.comp.returnValue();
data = 'function' === typeof dialogRef.value.comp.returnValue ? dialogRef.value.comp.returnValue() : undefined;
}
dialogRef.value.resolve(data);
dialogRef.value = null;
Expand Down