Skip to content

Rename Experiments #105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
May 11, 2020
Merged

Rename Experiments #105

merged 6 commits into from
May 11, 2020

Conversation

rjwats
Copy link
Owner

@rjwats rjwats commented May 10, 2020

Experimenting with renames, and splitting "core", and "util" code from "framework" code for clarity.

Introducing separate classes for Http GET/POST, Websocket Rx/Tx and Mqtt Pub/Sub.

@rjwats
Copy link
Owner Author

rjwats commented May 10, 2020

@kasedy

Some of the changes discussed in the other branch. I've not finished updating README.md.

@kasedy
Copy link
Contributor

kasedy commented May 11, 2020

PlatformIo suggests (teadme.txt in lib) to place the source code of each library in separate directory. Therefore if we still have a single library, "core" and "util" directories should be inside "framework". If it is three individual libraries we should come up with original names. I personally have /lib/util library with bunch of helpful functions that I copy over all my projects. I could be not the only one.

Apart that I like the changes. Right now I don't see a use case for http-post-only and WebsocketRx classes. But they might be usefully in future.

@rjwats
Copy link
Owner Author

rjwats commented May 11, 2020

I've moved the framework code back into a single lib directory for now. I like the idea of separation of class types, however I couldn't find a solution I was happy with. LDF is more complicated than I remember it.

Think there are so many changes in the PR that this may as well be parked for another PR once master is caught up any way. I'm going to merge these changes back into the feature branch, feature freeze, and work on the README, bug fixes and tidyups before getting this back in so we can work on the other stuff we've discussed. Feels like the big changes are nearly done.

@rjwats rjwats merged commit c74f770 into ft-mqtt-websockets May 11, 2020
@proddy
Copy link

proddy commented May 13, 2020

the LDF is tricky but it's possible to have separate source file folders and get platformio to build it successfully, using parameters in platformio.ini like for example build_flags = -I./src/Common and lib_ldf_mode=chain+. I can take a look if you want.

@rjwats rjwats deleted the rename-experiment branch May 29, 2020 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants