Test that checks that AttemptError can round trip properly
#31
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Follows up #27 to add a more elaborate test that checks that non-default job properties can unmarshal to `Job` property including `errors, which includes `AttemptError`. It turned out that of course this wasn't working properly.
brandur
force-pushed
the
brandur-attempt-error
branch
from
17cb7c4 to
522835b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follows up #27 to add a more elaborate test that checks that non-default
job properties can unmarshal to
Jobproperty includingerrors, which includesAttemptError`. It turned out that of course this wasn'tworking properly.