Implement insert many functions #22
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brandur
force-pushed
the
brandur-insert-many
branch
2 times, most recently
from
ca4b452 to
3b49483
Compare
Here, finish the implementations on `#insert_many` and `#insert_many_tx`, which were previously marked as not yet finished. The Python plugin for sqlc doesn't implement `copyfrom`, so we instead fall back on an alternative approach from an experimental `database/sql` branch I have, which implements an insert many operation using a combination of Postgres arrays and `unnest`. We remove some `Optional` annotations on `JobInsertParams` for properties that are always set by the client. (Necessary to make MyPy's checks pass properly.)
brandur
force-pushed
the
brandur-insert-many
branch
from
3b49483 to
efb0faf
Compare
brandur
added a commit
that referenced
this pull request
Jul 5, 2024
Tee up version 0.3.0, whose largest feature is a full implementation of `insert_many()` and `insert_many_tx()` [1]. [1] #22
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here, finish the implementations on
#insert_manyand#insert_many_tx,which were previously marked as not yet finished. The Python plugin for
sqlc doesn't implement
copyfrom, so we instead fall back on analternative approach from an experimental
database/sqlbranch I have,which implements an insert many operation using a combination of Postgres
arrays and
unnest.We remove some
Optionalannotations onJobInsertParamsfor propertiesthat are always set by the client. (Necessary to make MyPy's checks pass
properly.)