fix(iceberg): Introduce new data sequence for RewriteFilesAction #51
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chenzl25
approved these changes
May 22, 2025
Li0k
added a commit
that referenced
this pull request
Nov 13, 2025
* feat(iceberg): rewrite_files support use_starting_sequence_number * chore(test): add test_sequence_number_in_manifest_entry
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
What changes are included in this PR?
This PR fixes the Manifest Entry Seq error generated by RewriteFile Action. Provide new_data_sequence_number to set the entry sequence.
related to https://github.com/apache/iceberg/blob/dfa5a979437783877e0f4aedfb62943d4cfcdf8e/core/src/main/java/org/apache/iceberg/actions/RewriteDataFilesCommitManager.java#L74
https://github.com/apache/iceberg/blob/dfa5a979437783877e0f4aedfb62943d4cfcdf8e/core/src/main/java/org/apache/iceberg/MergingSnapshotProducer.java#L1051
Are these changes tested?