feat(iceberg): remove schemas #20
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZENOTME
approved these changes
Mar 10, 2025
ZENOTME
left a comment
ZENOTME
left a comment
There was a problem hiding this comment.
LGTM! We can track at upstream and include the link in this PR.
Author
Do you understand the upstream background? Can I directly contribute this interface to the upstream? @ZENOTME |
xxchan
pushed a commit
that referenced
this pull request
Mar 25, 2025
Xuanwo
pushed a commit
to apache/iceberg-rust
that referenced
this pull request
Apr 14, 2025
## Which issue does this PR close? <!-- We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123. --> ## What changes are included in this PR? This PR introduces the capability to remove schemas to enable expire snapshot action operations. https://github.com/apache/iceberg/blob/456bbe98b0b0982278a61af4c44d32e1c27417e2/core/src/main/java/org/apache/iceberg/TableMetadata.java#L1177 https://github.com/apache/iceberg/blob/456bbe98b0b0982278a61af4c44d32e1c27417e2/core/src/main/java/org/apache/iceberg/RemoveSnapshots.java#L249 refer to risingwavelabs#20 <!-- Provide a summary of the modifications in this PR. List the main changes such as new features, bug fixes, refactoring, or any other updates. --> ## Are these changes tested? - UT <!-- Specify what test covers (unit test, integration test, etc.). If tests are not included in your PR, please explain why (for example, are they covered by existing tests)? -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces the capability to remove schemas to enable expire snapshot action operations.
https://github.com/apache/iceberg/blob/456bbe98b0b0982278a61af4c44d32e1c27417e2/core/src/main/java/org/apache/iceberg/TableMetadata.java#L1177
https://github.com/apache/iceberg/blob/456bbe98b0b0982278a61af4c44d32e1c27417e2/core/src/main/java/org/apache/iceberg/RemoveSnapshots.java#L249