feat: add clone for DataFile #15
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xxchan
approved these changes
Mar 5, 2025
Collaborator
xxchan
left a comment
xxchan
left a comment
There was a problem hiding this comment.
Can this be submitted in upstream directly and it's time to do a rebase? Seems many of our PRs are merged upstream 🤔
Author
|
There are some pr still not merge in #10. To avoid blocking other pr, let's merge it first. I will rebase later.
In upstream we serialize datafile to avro so we don't need |
ZENOTME
merged commit 3e9763d
into
risingwavelabs:dev_rebase_main_20241230
1 check passed
chenzl25
pushed a commit
that referenced
this pull request
Mar 12, 2025
Co-authored-by: ZENOTME <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.