Return register operation result as int instead of boolean with 3 pos… #1
Conversation
…sible values. Handle wifi dialog notifications.
|
I am sorry for not having replied earlier. I would like to make some minor suggestions. I would have made these changes myself already, but unfortunately you haven't ticked the box for "allow edits by maintainers" for this pull request. (According to my knowledge it is possible to hit the edit button for this pull request and then change "allow edits by maintainers" afterwards.) Anyhow, my comments will follow now :) |
packages/wifi_iot/android/src/main/java/com/alternadom/wifiiot/WifiIotPlugin.java
Outdated
Show resolved
Hide resolved
packages/wifi_iot/android/src/main/java/com/alternadom/wifiiot/WifiIotPlugin.java
Outdated
Show resolved
Hide resolved
packages/wifi_iot/android/src/main/java/com/alternadom/wifiiot/WifiIotPlugin.java
Outdated
Show resolved
Hide resolved
packages/wifi_iot/lib/wifi_iot.dart
Outdated
| /// @returns True in case the requested network could be registered, false | ||
| /// otherwise. | ||
| static Future<bool> registerWifiNetwork( | ||
| /// @returns : |
There was a problem hiding this comment.
@returns Whether the network could be registered, the network failed to register, or the network is already registered.
I did'nt find the "allow edits by maintainers" option, I finished fixed, I let you review and resolve conversion. |
I checked and it's now on the right hand side of a pull request, right below the icons of the participants. |
|
I run some tests and confirmed on Android 14 that the correct values are all being returned (success, failed, alreadyRegistered). |
2 participants
@richirisu could you please review these changes ?