Skip to content

[C03] onClickItem -> onPressItem, onClickLegendItem -> onPressLegendItem #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 25, 2023
Merged

[C03] onClickItem -> onPressItem, onClickLegendItem -> onPressLegendItem #10

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/screens/C03LineChartWithLegendScreen/comps/LineChart/Legend/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,12 +12,12 @@ const NOT_VISIBLE_COLOR = 'gainsboro';
type LegendProps = LegendOptions & {
series: TimeSeries[];
linesOptions?: LinesOptions;
onClickItem?: (sr: TimeSeries, idx: number) => void;
onPressItem?: (sr: TimeSeries, idx: number) => void;
};
function Legend({
series,
linesOptions,
onClickItem,
onPressItem,

enabled = true,

Expand Down Expand Up @@ -68,7 +68,7 @@ function Legend({
paddingBottom: itemPaddingBottom ?? itemPadding ?? 2,
},
]}
onPress={() => onClickItem?.(sr, i)}
onPress={() => onPressItem?.(sr, i)}
>
<View
style={{
Expand Down
4 changes: 2 additions & 2 deletions src/screens/C03LineChartWithLegendScreen/comps/LineChart/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ function LineChart({

const loaded = xScale !== null && yScale !== null && lineFunc !== null;

const onClickLegendItem = (sr: TimeSeries, idx: number) => {
const onPressLegendItem = (sr: TimeSeries, idx: number) => {
setState(dr => {
dr.series = dr.series.map((sr, i) =>
i !== idx ? sr : { ...sr, visible: !sr.visible }
Expand Down Expand Up @@ -114,7 +114,7 @@ function LineChart({
<Legend
series={state.series}
linesOptions={linesOptions}
onClickItem={onClickLegendItem}
onPressItem={onPressLegendItem}
{...legendOptions}
/>
</View>
Expand Down