Skip to content

fix(gh-106): interpret game port as unsigned short #107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 6, 2022
Merged

fix(gh-106): interpret game port as unsigned short #107

merged 1 commit into from
Aug 6, 2022

Conversation

@DarkAtra
Copy link
Contributor

@DarkAtra DarkAtra commented Aug 6, 2022 •
edited
Loading

Fixes: #106

@DarkAtra DarkAtra changed the title fix(106): interpret game port as unsigned short fix(gh-106): interpret game port as unsigned short Aug 6, 2022
@ribasco ribasco self-requested a review August 6, 2022 15:41
@ribasco ribasco self-assigned this Aug 6, 2022
@ribasco ribasco removed their request for review August 6, 2022 15:44
@ribasco ribasco added the bug label Aug 6, 2022
ribasco
ribasco approved these changes Aug 6, 2022
View reviewed changes
Copy link
Owner

@ribasco ribasco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! Thanks for the PR

@ribasco ribasco merged commit 9629837 into ribasco:master Aug 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ribasco ribasco ribasco approved these changes

Assignees

@ribasco ribasco

Labels

bug source-query

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Game Server Port should be read as unsigned Short

2 participants

@DarkAtra @ribasco