Skip to content

chore: use fmt.Sprintf for YAML generation #577

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 11, 2024
Merged

chore: use fmt.Sprintf for YAML generation #577

merged 1 commit into from
Oct 11, 2024
+296 −38

Conversation

@simonpasquier
Copy link
Contributor

@simonpasquier simonpasquier commented Sep 27, 2024

No description provided.

@openshift-ci
Copy link

openshift-ci bot commented Sep 27, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@simonpasquier simonpasquier marked this pull request as ready for review September 27, 2024 12:17
@simonpasquier simonpasquier requested a review from a team as a code owner September 27, 2024 12:17
@simonpasquier simonpasquier requested review from JoaoBraveCoding and sthaha and removed request for a team September 27, 2024 12:17
@simonpasquier
Copy link
Contributor Author

simonpasquier commented Sep 27, 2024

/retest-required

@simonpasquier
Copy link
Contributor Author

simonpasquier commented Sep 30, 2024

/test observability-operator-e2e

@simonpasquier simonpasquier force-pushed the refactor-additional-config branch 3 times, most recently from 994be42 to 7e7289d Compare October 2, 2024 09:07
@jan--f
Copy link
Collaborator

jan--f commented Oct 2, 2024

Nice, thanks!
/lgtm

@openshift-ci openshift-ci bot added the lgtm label Oct 2, 2024
@simonpasquier
Copy link
Contributor Author

simonpasquier commented Oct 2, 2024

/test observability-operator-e2e

@simonpasquier simonpasquier force-pushed the refactor-additional-config branch from 7e7289d to a20ac25 Compare October 4, 2024 08:58
@openshift-ci openshift-ci bot removed the lgtm label Oct 4, 2024
@jan--f
Copy link
Collaborator

jan--f commented Oct 4, 2024

/lgtm
/retest

@openshift-ci openshift-ci bot added the lgtm label Oct 4, 2024
@simonpasquier simonpasquier force-pushed the refactor-additional-config branch from a20ac25 to 5edb2ff Compare October 4, 2024 11:53
@openshift-ci openshift-ci bot removed the lgtm label Oct 4, 2024
@openshift-ci
Copy link

openshift-ci bot commented Oct 4, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: simonpasquier

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@simonpasquier simonpasquier force-pushed the refactor-additional-config branch 2 times, most recently from 8d55eb8 to 6231867 Compare October 4, 2024 14:23
@simonpasquier
Copy link
Contributor Author

simonpasquier commented Oct 4, 2024

@jan--f the CI tests are broken by my change for now ;)

@simonpasquier simonpasquier requested a review from jan--f October 7, 2024 06:47
@simonpasquier simonpasquier force-pushed the refactor-additional-config branch from 6231867 to 5722d72 Compare October 7, 2024 06:48
@simonpasquier simonpasquier mentioned this pull request Oct 7, 2024
Merged
@jan--f
Copy link
Collaborator

jan--f commented Oct 8, 2024

/lgtm
/hold
not sure if this is supposed to go into 0.4.2. Feel free to unhold if so.

@simonpasquier
Copy link
Contributor Author

simonpasquier commented Oct 8, 2024

not sure if this is supposed to go into 0.4.2. Feel free to unhold if so.

No it can definitely wait after.

@simonpasquier
Copy link
Contributor Author

simonpasquier commented Oct 11, 2024

/hold cancel

@openshift-merge-bot openshift-merge-bot bot merged commit 447d539 into rhobs:main Oct 11, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sthaha sthaha Awaiting requested review from sthaha sthaha was automatically assigned from rhobs/observability-operator-maintainers

@JoaoBraveCoding JoaoBraveCoding Awaiting requested review from JoaoBraveCoding JoaoBraveCoding was automatically assigned from rhobs/observability-operator-maintainers

@marioferh marioferh Awaiting requested review from marioferh

@periklis periklis Awaiting requested review from periklis

@jan--f jan--f Awaiting requested review from jan--f

Assignees

@jan--f jan--f

Labels

approved lgtm

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@simonpasquier @jan--f