Skip to content

Conversation

Asraye
Copy link
Contributor

@Asraye Asraye commented Sep 1, 2025

Adds a "Copy User ID" selector on the user menu for ease of access
image

Please make sure to check the following tasks before opening and submitting a PR

  • I understand and have followed the contribution guide
  • I have tested my changes locally and they are working as intended

@insertish
Copy link
Member

I think this makes more sense to hide this away in settings (even at that, because I've seen some people get confused on whether that's what they share to get others to add them)?

To non developers, this is probably confusing
NB. copy ID buttons across the app should probably be gated now that I think about it

@Asraye
Copy link
Contributor Author

Asraye commented Sep 7, 2025

I think this makes more sense to hide this away in settings (even at that, because I've seen some people get confused on whether that's what they share to get others to add them)?

To non developers, this is probably confusing NB. copy ID buttons across the app should probably be gated now that I think about it

Could pull a Discord and hide it under developer mode (lol), Or we could make it similar to Revite where it's in the settings menu as you suggested — but I can confirm a lot of people struggled to realise that was just a UserID and not something sensitive. I think having it in the status menu makes it clear what it actually is. we could also add an info hover next to it explaining what it is and that It's not sensitive as well to make it more clear? Whether we went with the status or settings approach

@insertish
Copy link
Member

Okay this is fine now actually, I added a settings toggle for IDs

Copy link
Member

@insertish insertish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gate button behind advanced setting for IDs (see other context menus)

@github-project-automation github-project-automation bot moved this from 🆕 Untriaged to 🛑 Changes requested in Pull Request Overview Sep 7, 2025
@Asraye Asraye force-pushed the feat/usermenu-copyid branch from 13a7a2e to 4a95757 Compare September 7, 2025 17:15
@insertish insertish moved this from 🛑 Changes requested to 🆕 Untriaged in Pull Request Overview Sep 7, 2025
@Asraye
Copy link
Contributor Author

Asraye commented Sep 7, 2025

Gate button behind advanced setting for IDs (see other context menus)

Added – I've ran this through prettier as well this time, so.
Accidently removed the original commit with rebase, so it looks a bit weird now.

@github-project-automation github-project-automation bot moved this from 🆕 Untriaged to 💡 Ready to merge in Pull Request Overview Sep 12, 2025
@insertish insertish merged commit 9c304ce into revoltchat:main Sep 12, 2025
4 of 5 checks passed
@github-project-automation github-project-automation bot moved this from 💡 Ready to merge to ✅ Merged in Pull Request Overview Sep 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Merged
Development

Successfully merging this pull request may close these issues.

2 participants