Avoid typechecking val and def tpt-s twice #31
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on build pipelining + outline typing, I noticed we're doing some work twice.
I still need to understand why this results in some
Ident-s rather thanSelect-s appearing in typed trees inCodePrinterTest(e.gIdent(TypeName(Int)).setSymbol(symbolOf[scala.Int]). We should either restore the status quo, or make sure the more compact representation isn't going to break things (such asshowCode(tree, printRootPkg = true)in one of the tests I had to change the expectation)