Skip to content

Optimize EmptySet #116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: 2.12.x
Choose a base branch
from
Open

Optimize EmptySet #116

wants to merge 1 commit into from

Conversation

retronym
Copy link
Owner

No description provided.

@dwijnand
Copy link

Sounds too good to be true... does it pass mima?

@retronym
Copy link
Owner Author

@dwijnand Sadly no.

[error] scala-library: Failed binary compatibility check against org.scala-lang:scala-library:2.12.13! Found 2 potential problems (filtered 74)
[error]  * method intersect(scala.collection.GenSet)scala.collection.immutable.Set in object scala.collection.immutable.Set#EmptySet does not have a correspondent in other version
[error]    filter with: ProblemFilters.exclude[DirectMissingMethodProblem]("scala.collection.immutable.Set#EmptySet.intersect")
[error]  * method diff(scala.collection.GenSet)scala.collection.immutable.Set in object scala.collection.immutable.Set#EmptySet does not have a correspondent in other version
[error]    filter with: ProblemFilters.exclude[DirectMissingMethodProblem]("scala.collection.immutable.Set#EmptySet.diff")

Could still pull this up into a special case in the base class implementation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@retronym @dwijnand