Call interpreter.copyOperation consistently #4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this change,
Frame.executedid not invoke the interpreter'scopyOperationmethod for all values that are pushed on the frame'swhen executing some copying instructions.
For example, in the case of
SWAP,copyOperationis invoked:For
DUPon the other hand, the original value is pushed onto thestack without notifying the interpreter:
This leads to a problem for the
SourceInterpreter, which collectsfor every value a set of potential producer instructions. Given the
bytecode sequence
In the frame of the
INVOKESPECIALinstruction, the value on the stacklists as its producer the
NEWoperation instead of theDUP, whichnot expected.