Skip to content

Fix: get state should not return the number 0 as null #69

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
May 24, 2023
Merged

Fix: get state should not return the number 0 as null #69

merged 4 commits into from
May 24, 2023

Conversation

@gvdongen
Copy link
Contributor

@gvdongen gvdongen commented May 24, 2023 •
edited
Loading

  • The get state promise can be resolved with a Buffer or with Empty.
  • If a number 0 is stored, then this should not be converted to null by JSON.parse.
  • Add tests for storing 0 and "" and lists
  • Only return null if the state is Empty

This fixes #67

@gvdongen gvdongen self-assigned this May 24, 2023
@gvdongen gvdongen added this to the 1A milestone May 24, 2023
@gvdongen gvdongen merged commit 637c4f7 into main May 24, 2023
@gvdongen gvdongen deleted the issue#67 branch May 24, 2023 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@gvdongen gvdongen

Labels

None yet

Projects

None yet

Milestone

1A

Development

Successfully merging this pull request may close these issues.

Get and set state do not handle 0 and "" correctly

2 participants

@gvdongen