Wait for pending messages to be resolved before responding success #65
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jackkleeman
reviewed
May 24, 2023
| } | ||
| } | ||
|
|
||
| storePendingMsg( |
There was a problem hiding this comment.
this is a really good idea!
jackkleeman
approved these changes
May 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #52
The issue: In the case of a replay of messages that do not require completion (e.g. set state and then output response),
the state machine did not wait until the replay had finished before sending back the response and closing the state machine.
So if the set state had to be replayed, then the user code just skipped it and continued to send back the response.
Fix: wait for all the promises in the pending messages map to be resolved before sending back the response.
This avoids warnings like State machine is closed. Cancelling all execution. And makes sure journal mismatch checks are always done.