Skip to content

Conversation

@jfrolich
Copy link
Collaborator

No description provided.

@pkg-pr-new
Copy link

pkg-pr-new bot commented Oct 18, 2025

Open in StackBlitz

rescript

npm i https://pkg.pr.new/rescript-lang/rescript@7971

@rescript/darwin-arm64

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/darwin-arm64@7971

@rescript/darwin-x64

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/darwin-x64@7971

@rescript/linux-arm64

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/linux-arm64@7971

@rescript/linux-x64

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/linux-x64@7971

@rescript/runtime

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/runtime@7971

@rescript/win32-x64

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/win32-x64@7971

commit: 1d2aec3

@cknitt
Copy link
Member

cknitt commented Oct 19, 2025

@jfrolich Emoji definitions for the now unused steps can be removed.

Output for clean does not look optimal:

[1/2] 🧹 Cleaned compiler assets in 0.12s
[2/2] 🧹 Cleaning  files...
[2/2] 🧹 Cleaned  files in 0.00s

@cknitt
Copy link
Member

cknitt commented Oct 19, 2025

Now it says

[1/2] 🧹 Cleaned compiler assets in 0.15s
[2/2] 🧹 Cleaned  files in 0.00s

(so either there is a space too much, or the number of files that were cleaned is missing)

CHANGELOG.md Outdated

- Rewatch: plain output when not running in tty. https://github.com/rescript-lang/rescript/pull/7970
- Streamline rewatch help texts. https://github.com/rescript-lang/rescript/pull/7973
- Rewatch: Reduced build progress output from 7 steps to 3 for cleaner, less verbose logging
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is missing the link to the issue.

Other than that, the PR looks good to me now. Thanks @jfrolich!

@fhammerschmidt Please merge and add the link when you build rc.3 tonight.

@jfrolich
Copy link
Collaborator Author

Can't merge it:
image

@fhammerschmidt fhammerschmidt merged commit cd6bc43 into master Oct 24, 2025
25 checks passed
@fhammerschmidt fhammerschmidt deleted the reduce-logs branch October 24, 2025 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants