Skip to content

preserve URI format in canonicalizeUri #990

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 27, 2024
Merged

preserve URI format in canonicalizeUri #990

merged 1 commit into from
May 27, 2024

Conversation

WhyThat
Copy link
Contributor

@WhyThat WhyThat commented May 27, 2024

This PR addresses a bug in the canonicalizeUri function that was causing issues with the go to definition feature in Neovim.

@fhammerschmidt
Copy link
Member

thanks, this was what I was actually missing, now I can do a little cleanup

@fhammerschmidt fhammerschmidt merged commit ac2f38b into rescript-lang:master May 27, 2024
@fhammerschmidt fhammerschmidt mentioned this pull request May 27, 2024
Merged
@WhyThat WhyThat deleted the fix-canonicalizeUri branch May 28, 2024 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@WhyThat @fhammerschmidt