Skip to content

Upgrade Github actions to v4 to fix deprecation warnings #949

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 11, 2024
Merged

Upgrade Github actions to v4 to fix deprecation warnings #949

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 13 additions & 13 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,10 +45,10 @@ jobs:
git config --global core.autocrlf false
git config --global core.eol lf

- uses: actions/checkout@v3
- uses: actions/checkout@v4

- name: Cache OCaml's opam
uses: actions/cache@v3
uses: actions/cache@v4
with:
path: ~/.opam
key: ${{matrix.os}}-rescript-vscode-v4
Expand All @@ -59,7 +59,7 @@ jobs:
ocaml-compiler: 4.14.x

- name: Use Node.js
uses: actions/setup-node@v3
uses: actions/setup-node@v4
with:
node-version: 16
registry-url: 'https://registry.npmjs.org'
Expand Down Expand Up @@ -89,7 +89,7 @@ jobs:
mv rescript-tools.exe ${{matrix.artifact-folder}}
tar -cvf binary.tar ${{matrix.artifact-folder}}

- uses: actions/upload-artifact@v3
- uses: actions/upload-artifact@v4
with:
name: ${{matrix.os}}
path: binary.tar
Expand All @@ -99,10 +99,10 @@ jobs:
runs-on: ubuntu-20.04

steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4

- name: Use Node.js
uses: actions/setup-node@v3
uses: actions/setup-node@v4
with:
node-version: 16
registry-url: 'https://registry.npmjs.org'
Expand All @@ -111,31 +111,31 @@ jobs:
- run: npm run compile

- name: Download MacOS binary
uses: actions/download-artifact@v3
uses: actions/download-artifact@v4
with:
name: macos-13
path: binaries
- run: tar -xvf binary.tar
working-directory: binaries

- name: Download MacOS ARM binary
uses: actions/download-artifact@v3
uses: actions/download-artifact@v4
with:
name: macos-14
path: binaries
- run: tar -xvf binary.tar
working-directory: binaries

- name: Download Linux binary
uses: actions/download-artifact@v3
uses: actions/download-artifact@v4
with:
name: ubuntu-20.04
path: binaries
- run: tar -xvf binary.tar
working-directory: binaries

- name: Download Windows binary
uses: actions/download-artifact@v3
uses: actions/download-artifact@v4
with:
name: windows-latest
path: binaries
Expand Down Expand Up @@ -191,19 +191,19 @@ jobs:
if: startsWith(github.ref, 'refs/tags/')
run: npx vsce package -o rescript-vscode-${{ steps.tag_name.outputs.tag }}.vsix ${{ steps.tag_name.outputs.tag }} --no-git-tag-version

- uses: actions/upload-artifact@v3
- uses: actions/upload-artifact@v4
if: github.ref != 'refs/heads/master'
with:
name: rescript-vscode-${{ steps.vars.outputs.sha_short }}.vsix
path: rescript-vscode-${{ steps.vars.outputs.sha_short }}.vsix

- uses: actions/upload-artifact@v3
- uses: actions/upload-artifact@v4
if: github.ref == 'refs/heads/master'
with:
name: rescript-vscode-latest-master.vsix
path: rescript-vscode-latest-master.vsix

- uses: actions/upload-artifact@v3
- uses: actions/upload-artifact@v4
if: startsWith(github.ref, 'refs/tags/')
with:
name: rescript-vscode-${{ steps.tag_name.outputs.tag }}.vsix
Expand Down