Skip to content

Fix jsx wrapping in completion #718

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 31, 2023
Merged

Fix jsx wrapping in completion #718

merged 2 commits into from
Jan 31, 2023

Conversation

zth
Copy link
Collaborator

@zth zth commented Jan 31, 2023

Didn't account for nested values when deciding when to insert braces for JSX prop values when completing.

@zth zth requested a review from cristianoc January 31, 2023 09:06
cristianoc
cristianoc approved these changes Jan 31, 2023
View reviewed changes
Copy link
Collaborator

@cristianoc cristianoc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch.

@zth zth merged commit d51db47 into master Jan 31, 2023
@zth zth deleted the fix-jsx-wrapping-in-completion branch January 31, 2023 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cristianoc cristianoc cristianoc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zth @cristianoc